Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paths config option #288

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Add paths config option #288

merged 3 commits into from
Apr 25, 2022

Conversation

driftingly
Copy link
Member

This PR aims to close #287

Paths can be provided as a single string or an array.

@driftingly
Copy link
Member Author

Looks like I'll need to remove some PHP 7.4 code.
@bakerkretzmar we don't need to do this now, but how would you feel about bumping the min PHP to 7.4 in the next release.

Copy link
Contributor

@bakerkretzmar bakerkretzmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this @driftingly!! Merge whenever 👍🏻

As for bumping the PHP version, I'm all for it. Let's talk about it more, but in a major version bump I think we could probably even go to PHP 8.

@driftingly driftingly merged commit de4f855 into main Apr 25, 2022
@driftingly driftingly deleted the adc/add-paths-config branch April 25, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customizable paths in config
2 participants