-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #309
Merged
Merged
Refactor tests #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites almost all of Ziggy's tests. It moves us from Mocha to Jest, adds tests for several recent PRs and some edge cases, and cleans up / restructures our test files and the tests themselves. Notably, this also removes the step of running webpack before tests.
I only removed one thing worth mentioning: our tests related to axios. I'm pretty sure they actually weren't running correctly before (the promises weren't returned so they were getting swallowed and no assertions were actually being made), but using both AVA and Jest I couldn't consistently get
axios.get(route('name'))
to actually work, andaxios.get(route('name').url())
isn't worth testing because anything it does is covered by our other tests.Also sneaking into this PR:
useBuiltIns: false
from our Babel config (it's the default value)> 2%, last 2 versions
todefaults, not IE 11
(only about a 0.7% difference in global coverage)