Fix routes order to work with fallback() method #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts the route list into the correct order when the
fallback()
method is used.The code is taken directly from Laravel core:
https://github.com/laravel/framework/blob/29c64cb6c1d8cc712463c63fcf60c0a46fe3455e/src/Illuminate/Routing/AbstractRouteCollection.php#L77-L81
More detailed explanation:
If the routes are defined as:
And you are on
/something
then Laravel returns thesomething
page, but Ziggy'sroute().current()
method currently returnserrors.404
, androute().current('something')
returnsfalse
.(In this trivial example you could, of course, reorder the routes - but they are actually split across several packages.)