Avoid wrapping Artisan command --url option with url() helper when possible #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #359, but note that it doesn't fix that particular issue—the cause of that issue is an invalid
APP_URL
, which is a case that Laravel and Ziggy do not officially support.What that issue raised, though, was the fact that we're now applying the
url()
helper inconsistently. In #334 we updated theZiggy
class to preferAPP_URL
over theurl()
helper, but I missed the fact that theCommandRouteGenerator
class was still always wrapping its--url
option with theurl()
helper—even when the--url
option isnull
.This PR ensures that if no
--url
option is passed, the generate command passes thatnull
option on to theZiggy
class to handle properly.Before
--url
option tophp artisan ziggy:generate
usesurl('/')
--url
option uses that URL directly--url
option usesurl($this->option('url'))
After
--url
option tophp artisan ziggy:generate
usesconfig('app.url', url('/'))
--url
option uses that URL directly (unchanged)--url
option usesurl($this->option('url'))
(unchanged)