Ensure Ziggy.defaults is always an object #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #366 by ensuring that the JavaScript
Ziggy.defaults
property is always an object, even when it's empty.The bug in #366 happens because previously, when
defaults
was an empty PHP array, it was encoded as an empty JavaScript array too. JavaScript arrays of course have several built-in methods, likeshift()
andreduce()
, and so if you had a route parameter name that matched one of those methods, and you tried to access it on an array, it would return that method:If there are default parameters,
defaults
will be an object, which avoids this issue, but if there aren't, it would have been an array, so any route parameter names matching built-in JavaScript array methods would cause errors like this.