Revert #334 "Use APP_URL instead of url() helper" #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been digging down thinking it's because of my S3 deployment. This needs to be merged ASAP. |
jakebathman
approved these changes
Dec 6, 2020
|
Quick review looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #334 and switches back to using
url('/')as the base URL, instead of the value of theAPP_URLenvironment variable. That change caused subdomains and ports to stop working, which are both quite common use cases.This PR will cause issues again in environments like those described in #313. @claudiodekker I'll work an alternative solution—sorry to break this again, but it's ended up causing more problems than it solved.
Fixes #383, fixes #376, and fixes #374.