Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove template literal to be es5 compliant #5

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

TimBest
Copy link
Contributor

@TimBest TimBest commented Sep 4, 2018

No description provided.

@tigt
Copy link
Owner

tigt commented Oct 7, 2018

Yeah, okay. I don't know why that's important but I trust there's some reason.

@Gyllsdorff
Copy link

@tigt
From the README.md

Internet Explorer 9 and up, including Edge

Template strings are not supported by IE.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#Browser_compatibility

@tigt
Copy link
Owner

tigt commented Nov 24, 2018

@Gyllsdorff: Ah, I had meant that the generated SVG output data: URI works in those browsers, not the JS itself. I should make that clearer.

@Gyllsdorff
Copy link

Gyllsdorff commented Nov 25, 2018

Ah, I see.

The company I work at have this embedded in the browser js bundle so this line stops us from supporting IE11. Of course we can add a babel transpilation step for this dependency or fork it and fix it ourselves but it would be much better (for us 😄) if this PR could be merged and released.

@Gyllsdorff
Copy link

@tigt
Is there anything I can do to help this get merged and released?

@tigt tigt merged commit a17bccb into tigt:master Nov 26, 2018
@tigt
Copy link
Owner

tigt commented Nov 26, 2018

@Gyllsdorff That ping was sufficient, I just needed to remember when I was on my laptop.

Should be published as 1.0.2, but let me know if I did something wrong.

@Gyllsdorff
Copy link

Thank you, great work. 👍

The release is npm (https://www.npmjs.com/package/mini-svg-data-uri) now. It is not visible in the web UI yet but if you go to https://www.npmjs.com/package/mini-svg-data-uri/v/1.0.2 you can see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants