Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions to Latest Version #240

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ssrcdevops
Copy link
Collaborator

GitHub Actions Version Updates

Copy link
Contributor

@mkaapu mkaapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these tool versions be values of variables, so that you would need to change these version numbers only in one place? Not sure if this can be done, not really used GitHub actions.

@henrirosten
Copy link
Collaborator

Please make sure this is not merged without testing

@karim20230
Copy link
Member

Please make sure this is not merged without testing

tested in my fork https://github.com/karim20230/ghaf-infra
https://github.com/karim20230/ghaf-infra/pull/3

@henrirosten
Copy link
Collaborator

henrirosten commented Sep 12, 2024

Please make sure this is not merged without testing

tested in my fork https://github.com/karim20230/ghaf-infra karim20230#3

@karim20230:
Just for the sake of clarify,
can you give direct links to the github action logs on your repo from successful run with each of the updated action:

@karim20230
Copy link
Member

karim20230 commented Sep 12, 2024

Please make sure this is not merged without testing

tested in my fork https://github.com/karim20230/ghaf-infra karim20230#3

@karim20230: Just for the sake of clarify, can you give direct links to the github action logs on your repo from successful run with each of the updated action:

* [Check Commit Message](https://github.com/tiiuae/ghaf-infra/blob/03ecbd72451e95b0a0b47318a8afb068118e493c/.github/workflows/check-commit-message.yaml)

* [GitHub Actions Version Updater](https://github.com/tiiuae/ghaf-infra/blob/03ecbd72451e95b0a0b47318a8afb068118e493c/.github/workflows/schedule-update-actions.yml)

* [Run pre-push checks](https://github.com/tiiuae/ghaf-infra/blob/03ecbd72451e95b0a0b47318a8afb068118e493c/.github/workflows/test-ghaf-infra.yml)

well you can see the logs from here ? it's same fails as here, basically commit msg , sign-off etc please look https://github.com/karim20230/ghaf-infra/actions/runs/10809635345

-and commit msg , sign-off check failing because of remote user ?

@karim20230
Copy link
Member

karim20230 commented Sep 12, 2024

Please make sure this is not merged without testing

tested in my fork https://github.com/karim20230/ghaf-infra karim20230#3

@karim20230: Just for the sake of clarify, can you give direct links to the github action logs on your repo from successful run with each of the updated action:

* [Check Commit Message](https://github.com/tiiuae/ghaf-infra/blob/03ecbd72451e95b0a0b47318a8afb068118e493c/.github/workflows/check-commit-message.yaml)

* [GitHub Actions Version Updater](https://github.com/tiiuae/ghaf-infra/blob/03ecbd72451e95b0a0b47318a8afb068118e493c/.github/workflows/schedule-update-actions.yml)

* [Run pre-push checks](https://github.com/tiiuae/ghaf-infra/blob/03ecbd72451e95b0a0b47318a8afb068118e493c/.github/workflows/test-ghaf-infra.yml)

another usual notification

Run if [ "true" == "true" ]; then
Error: This change edits workflow file '.github/workflows/test-ghaf-infra.yml'. Raising this error to notify that the workflow change will only take impact after merge. Therefore, you need to manually test the change (perhaps in a forked repo) before merging to make sure the change does not break anything.
Error: Process completed with exit code 1.

@karim20230
Copy link
Member

karim20230 commented Sep 12, 2024

And I also take a look on ghafscan how we deal with remote user, auto scan etc, then I noticed we don't have commit msg or sign-off checker action there

@karim20230
Copy link
Member

@karim20230 karim20230 merged commit 99ca2ad into main Sep 13, 2024
3 of 5 checks passed
@karim20230 karim20230 deleted the gh-actions-update-1725874969 branch September 13, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants