-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple installer #249
Add simple installer #249
Conversation
Please also squash all the commits into one when you fix the |
18fb58a
to
cd79a16
Compare
cd79a16
to
0ad8add
Compare
6205921
to
7034358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general - looks good to me as the first iteration of installer. Building this now for testing.
7034358
to
ee11548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix installer for generic.
f93cbd1
to
bf901d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified to work on X1 with .#nixosConfigurations.generic-x86_64-debug.config.system.build.installer
.
The basic structure looks good baseline for further work.
@mikatammi @brianmcgillion - please consired reviewing / merging this soon so further work can be based on it.
5b4fbbe
to
60e7f28
Compare
Adds function that generates installer for desired configuration that builds raw-efi image. Also add target that build installer image for generic-x86_64-release as example. Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
60e7f28
to
44739f4
Compare
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
44739f4
to
3cca0e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments:
-- Make a separate subsection 5.1.2.
-- Change the main title + change Built-in Installer Modules
-- Make a list of actions instead of plain text.
-- Add reference to https://tiiuae.github.io/ghaf/ref_impl/modules_options.html
-- nix -> Nix
@remimimimimi, do not forget to change ghaf -> Ghaf ( ` ω ´ ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After retesting this together with @remimimimimi - this is not working correctly. The image written to the internal memory is not booting correctly to the desktop.
The problem is that we only get very few early boot logs to the display - then just black display. No IP via DHCP like with the target image booted from SSD.
All I can think now for debug is to print the partitions of nvme0n1
after sync
and sleep 20s - here https://github.com/tiiuae/ghaf/pull/249/files#diff-789892fdf4e4c650d81ce42dbc84586807ced5e73a8d53c06775acf7df2d0876R172
Then add a message like: echo "Rebooting automatically in 20 seconds.
If that does not help, we need to check if we can get early kernel logs either to display or to USB debugging - https://docs.kernel.org/driver-api/usb/usb3-debug-port.html
@remimimimimi - this fixes the issue on X1
kudos @mikatammi for thinking out loud about possibly missing nvme kernel module - I remember I had to add |
5c5521b
to
a7c7c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Let's play a little bit more with letters :D
a7c7c42
to
9fa37a8
Compare
I tested the installer and there are some rough edges, for example I was staring away from laptop while it was installing, then it rebooted, and I wasn't fast enough to disconnect the USB-drive. So the system somehow strangely booted up into ghaf desktop but still something was mounted from USB-drive. But I'm fine with merging this now and improving things later. |
Note for the future: Also the resulting image was 26 gigabytes, so adding (zstd) compression even to the image embedded, would save many gigabytes |
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
Without `nvme` kernel module it doesn't boot's up after installation. Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
9fa37a8
to
d9966cb
Compare
Adds simple CLI based installer that runs at system startup (installer image) and flushes image with which we configured it to the target device. Also allows anyone to build an installer for their configuration if it builds raw-efi image.