Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate appvm mac addresses automatically #535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remimimimimi
Copy link
Contributor

@remimimimimi remimimimimi commented Mar 28, 2024

Description of changes

This PR implements an allocator for appvm’s MAC addresses and their collision detector, following current convention “02:00:00:03:{n}:01”. Allows up to 256 addresses to be assigned automatically.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Installed lenovo-x1-gen-11-debug image on the hardware and tried to run virtual machines.

Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
vms,
}: vm: let
allocated =
if vm.macAddress == null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiiuae tiiuae deleted a comment Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants