Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USB network card kernel patch #550

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

mikatammi
Copy link
Contributor

@mikatammi mikatammi commented Apr 9, 2024

Description of changes

Fix MAC-address randomized on USB network cards because of kernel bug. This specifically affects network cards used in testing.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@mikatammi mikatammi temporarily deployed to internal-build-workflow April 9, 2024 14:24 — with GitHub Actions Inactive
@mikatammi mikatammi temporarily deployed to internal-build-workflow April 9, 2024 14:29 — with GitHub Actions Inactive
@mikatammi mikatammi temporarily deployed to internal-build-workflow April 9, 2024 14:41 — with GitHub Actions Inactive
Fix MAC-address randomized on USB network cards because of kernel bug.
This specifically affects network cards used in testing.

Signed-off-by: Mika Tammi <mika.tammi@unikie.com>
@mikatammi mikatammi temporarily deployed to internal-build-workflow April 9, 2024 14:43 — with GitHub Actions Inactive
@mikatammi mikatammi marked this pull request as ready for review April 9, 2024 17:15
@brianmcgillion brianmcgillion merged commit c7cc82b into tiiuae:main Apr 9, 2024
13 checks passed
@mikatammi mikatammi deleted the usb-network-kernel-patch branch April 9, 2024 17:26
@flokli
Copy link

flokli commented Apr 10, 2024

Linux-stable has been cc'ed in the upstream patch, so this will likely end up trickling into the nixpkgs-provided kernel too at some point - and then the patch here will also fail to apply (as it's already applied) - independently of the eval issue in #551.

Can we apply this patch unconditionally, and simply remove it once we bumped nixpkgs to a kernel including the patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants