Offline installer fix #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
force-pushed
the
offline-installer-fix
branch
from
d6c88f0
to
2489be6
Compare
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
commented
Apr 23, 2024
tests/installer/default.nix
Outdated
| @@ -40,7 +40,7 @@ pkgs.nixosTest { | |||
|
|
|||
| print(machine.succeed("tty")) | |||
|
|
|||
| machine.succeed("disko-install --disk ${disk} /dev/vdb --flake ${self}#${testConfig}") | |||
| machine.succeed("disko-install --write-efi-boot-entries --disk ${disk} /dev/vdb --flake ${self}#${testConfig}") | |||
There was a problem hiding this comment.
@remimimimimi that's a very subtle difference. Let me fix this in nixpkgs actually.
The issue is that disko-install needs to override the NixOS configuration to disable writing efi vars as the default because it would be not fit as a USB flasher if it would make the system it's running on unbootable.
There was a problem hiding this comment.
That in turn triggered a rebuild of systemd-boot-builder.
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
Mic92
force-pushed
the
offline-installer-fix
branch
from
7aeb6b7
to
9d7b69a
Compare
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Mic92
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
|
I also fixed NixOS to not require boot install script checks rebuilds when the nixos configuration changes: NixOS/nixpkgs#306339 |
|
I believe this is part of #585 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Checklist for things done
x86_64aarch64riscv64nix flake check --accept-flake-configand it passesTesting