Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock the screen when Yubikey hardware is plugged out #707

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Lock the screen when Yubikey hardware is plugged out #707

merged 1 commit into from
Aug 7, 2024

Conversation

vunnyso
Copy link
Contributor

@vunnyso vunnyso commented Aug 1, 2024 •
edited
Loading

  • Add udev rule for Yubikey hardware such that once Yubikey is plugged out of system, screen should lock automatically.
  • Starting swayidle lock in labwc autostart.

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Prerequisite
Yubikey hardware, more details here

Steps:

  1. Plugin the Yubikey Hardware
  2. Plugout the Yubikey Hardware
  3. After plugout screen locker will appear automatically.

@vunnyso vunnyso temporarily deployed to internal-build-workflow August 1, 2024 13:44 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Aug 2, 2024
@vunnyso vunnyso temporarily deployed to internal-build-workflow August 2, 2024 11:52 — with GitHub Actions Inactive
@vunnyso vunnyso temporarily deployed to internal-build-workflow August 2, 2024 12:10 — with GitHub Actions Inactive
@vunnyso
Lock the screen when Yubikey hardware is plugged out
b16f243 
* Add udev rule for Yubikey hardware such that once
  Yubikey is plugged out of system, screen should
  lock automatically.
* Starting swayidle lock in labwc autostart.

Signed-off-by: Vunny Sodhi <vunny.sodhi@unikie.com>
@vunnyso vunnyso temporarily deployed to internal-build-workflow August 7, 2024 07:06 — with GitHub Actions Inactive
@milva-unikie
Copy link

Tested on Lenovo-X1

Everything is ok!

  • Plugging the Yubikey in and then taking it out locks the laptop
  • Laptop can be opened with Yubikey, password or with fingerprint if one is enrolled
  • Test-automation passes
  • Performance ok

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Aug 7, 2024
@brianmcgillion brianmcgillion merged commit 6cef841 into tiiuae:main Aug 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humaidq-tii humaidq-tii humaidq-tii approved these changes

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vilvo vilvo vilvo approved these changes

@avnik avnik Awaiting requested review from avnik

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vunnyso @milva-unikie @vilvo @brianmcgillion @humaidq-tii