Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Halow MTU handling #456

Merged
merged 3 commits into from
May 14, 2024
Merged

Change Halow MTU handling #456

merged 3 commits into from
May 14, 2024

Conversation

joenpera
Copy link
Collaborator

Now halow MTU is tried to set instead of printing error.

Jira-Id: SECO-5358

joenpera and others added 2 commits May 13, 2024 13:01
@joenpera
Change Halow MTU handling
e437474 
Now halow MTU is tried to set instead of printing error.

Jira-Id: SECO-5358

Signed-off-by: Mika Joenpera <mika.joenpera@unikie.com>
@joenpera
Merge branch 'develop' into halow_mtu_handling_change
e397a53
@joenpera joenpera self-assigned this May 13, 2024
pentestiing
pentestiing suggested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@pentestiing pentestiing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌋

modules/sc-mesh-secure-deployment/src/nats/src/cbma_adaptation.py Show resolved Hide resolved
@joenpera
Fix review findings
78001c8 
Jira-Id: SECO-5358

Signed-off-by: Mika Joenpera <mika.joenpera@unikie.com>
@saauvine saauvine self-requested a review May 14, 2024 05:37
pentestiing
pentestiing approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@pentestiing pentestiing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lil' optional improvement suggested above 🗼

@joenpera
Copy link
Collaborator Author

There's a lil' optional improvement suggested above 🗼

I created a backlog item to check all subprocess calls and use check_call when output is not needed.

@joenpera joenpera merged commit 1c38941 into develop May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentestiing pentestiing pentestiing approved these changes

@TIISR TIISR TIISR approved these changes

@saauvine saauvine saauvine approved these changes

Assignees

@joenpera joenpera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joenpera @saauvine @TIISR @pentestiing