This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
E2E Testing #12
Open
E2E Testing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
======================================
Coverage 65.5% 65.5%
======================================
Files 2 2
Lines 229 229
======================================
Hits 150 150
Misses 67 67
Partials 12 12Continue to review full report at Codecov.
|
hawarir
reviewed
Sep 9, 2019
test/e2e/e2e.py
Outdated
| # === | ||
| print("Creating containers ...") | ||
|
|
||
| redis_src_container = run_container( |
There was a problem hiding this comment.
Can we wrap the run_container used by the backing Redis into another function? The only parameters that differs are the name and dbfilename, it would help the run_test readibility, which is already quite long as it is.
hawarir
reviewed
Sep 11, 2019
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this settings essential for the build? If not, can it be gitignored?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read
test/e2e/README.md