Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table builder test #14

Merged
merged 7 commits into from
Oct 14, 2020
Merged

add table builder test #14

merged 7 commits into from
Oct 14, 2020

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Oct 13, 2020

This PR adds (placeholders of) table builder tests. TODOs will be filled in after full table module is complete.

@skyzh skyzh mentioned this pull request Oct 13, 2020
31 tasks
src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/table/builder.rs Outdated Show resolved Hide resolved
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from BusyJay October 13, 2020 09:13
@skyzh skyzh merged commit 49b14a6 into master Oct 14, 2020
@skyzh skyzh deleted the add-table-builder-test branch October 14, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants