region_cache: rename LocateBucketV2 to LocateBucket and let the old LocateBucket be the internal function of the new LocateBucket #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>
SpadeA-Tang
changed the title
internal/locate/region_cache.go
Outdated
| func (l *KeyLocation) LocateBucketV2(key []byte) *Bucket { | ||
| bucket := l.LocateBucket(key) | ||
| // LocateBucket calls locateBucket and check the result. | ||
| // When the key is in [ KeyLocation.StartKey, first Bucket key ), the result returned by locateBucket will be nil |
There was a problem hiding this comment.
Please remove the space to unify the format.
Suggested change
| // When the key is in [ KeyLocation.StartKey, first Bucket key ), the result returned by locateBucket will be nil | |
| // When the key is in [KeyLocation.StartKey, first Bucket key), the result returned by locateBucket will be nil |
internal/locate/region_cache.go
Outdated
| bucket := l.LocateBucket(key) | ||
| // LocateBucket calls locateBucket and check the result. | ||
| // When the key is in [ KeyLocation.StartKey, first Bucket key ), the result returned by locateBucket will be nil | ||
| // as there's no bucket containing this key. LocateBucket will return Bucket{ KeyLocation.StartKey, first Bucket key } |
There was a problem hiding this comment.
Suggested change
| // as there's no bucket containing this key. LocateBucket will return Bucket{ KeyLocation.StartKey, first Bucket key } | |
| // as there's no bucket containing this key. LocateBucket will return Bucket{KeyLocation.StartKey, first Bucket key} |
youjiali1995
approved these changes
May 13, 2022
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SpadeA-Tang u6748471@anu.edu.au