Add gRPC local subchannel support for tikv client. #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yulai.li <blacktear23@gmail.com>
blacktear23
force-pushed
the
grpc-subchannel
branch
from
c2835c7
to
78dfbf7
Compare
ekexium
reviewed
Mar 21, 2022
| let cb = ChannelBuilder::new(env) | ||
| .keepalive_time(Duration::from_secs(10)) | ||
| .keepalive_timeout(Duration::from_secs(3)); | ||
| .keepalive_timeout(Duration::from_secs(3)) | ||
| .raw_cfg_int(CString::new("grpc.use_local_subchannel_pool").unwrap(), 1); |
There was a problem hiding this comment.
raw_cfg_int is not intended to be used directly according to its doc. I think it would be better to add a method grpc-rs to set it.
There was a problem hiding this comment.
OK, I will create a PR for grpc-rs first. But this is the easy way to set the configuration at rust-client side.
And why not grpc-rs not provide a method like set_config_int(&str, int).
|
@ekexium tikv/grpc-rs#565 is created. |
|
@blacktear23 any update to this pr? |
|
@yongman nothing changed, we can go ahead with your pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As default configuration gRPC will reuse TCP connections to each TiKV server what ever how many TiKV client instance created. This PR will enable
grpc. use_local_subchannel_poolsettings to ensure every TiKV client will create it self owned TCP connections to TiKV (or PD).This will help to use more CPU when heavy load on gRPC calls. And as default settings it will make user confused when create many TiKV client but OS shows only one TCP connection to each TiKV server.