Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support some configs for ping. #137

Merged
merged 1 commit into from
Dec 25, 2017
Merged

support some configs for ping. #137

merged 1 commit into from
Dec 25, 2017

Conversation

disksing
Copy link
Contributor

No description provided.

@siddontang
Copy link
Contributor

do we have any test for channel options?

BusyJay
BusyJay reviewed Dec 23, 2017
View reviewed changes
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need GRPC_ARG_KEEPALIVE_TIME_MS, GRPC_ARG_KEEPALIVE_TIMEOUT_MS，
GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS.

@disksing
Copy link
Contributor Author

@siddontang No. Didn't find any test for other parameters either.
@BusyJay They already exist.

@siddontang
Copy link
Contributor

@disksing

Please file an issue that we must add some tests.

Now LGTM

overvenus
overvenus approved these changes Dec 25, 2017
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing mentioned this pull request Dec 25, 2017
Open
@disksing disksing changed the title support some configs for ping. [DNM] support some configs for ping. Dec 25, 2017
@disksing disksing changed the title [DNM] support some configs for ping. support some configs for ping. Dec 25, 2017
@disksing
Copy link
Contributor Author

Tested with tikv-server. It works. Merging.

@disksing disksing merged commit 4b8a4eb into tikv:master Dec 25, 2017
@disksing disksing deleted the ping branch December 25, 2017 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay left review comments

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @siddontang @BusyJay @overvenus