Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support getting real source address of HTTP requests #6598

Closed
rleungx opened this issue Jun 14, 2023 · 0 comments · Fixed by #6622
Closed

Support getting real source address of HTTP requests #6598

rleungx opened this issue Jun 14, 2023 · 0 comments · Fixed by #6622
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Jun 14, 2023

Enhancement Task

The current implementation of HTTP request forwarding doesn't add X-Forwarded-For header to the request. Once the PD follower receives the request and forwards it to the leader, the leader can only know it coming from the follower. But we need to know the real source IP of the request.
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Jun 14, 2023
@rleungx rleungx mentioned this issue Jun 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 20, 2023
@rleungx @nolouch
api: support record the caller IP when forwarding (#6622)
58d9208 
close #6595, close #6598

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 1, 2023
@rleungx @nolouch
api: support record the caller IP when forwarding (tikv#6622)
a57ddc9 
close tikv#6595, close tikv#6598

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: support record the caller IP when forwarding rleungx/pd
1 participant
@rleungx