-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetRegions: stop process and release resources when the connection is disconnected. #6835
Labels
affects-6.5
affects-6.6
affects-7.0
affects-7.1
affects-7.2
type/enhancement
The issue or PR belongs to an enhancement.
Comments
AndreMouche
added
the
type/enhancement
The issue or PR belongs to an enhancement.
label
Jul 24, 2023
@lhy1024 Please take a look, thanks. |
ti-chi-bot bot
added a commit
that referenced
this issue
Jul 27, 2023
close #6835 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Jul 27, 2023
close tikv#6835 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
pushed a commit
to ti-chi-bot/pd
that referenced
this issue
Oct 8, 2023
close tikv#6835 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
18 tasks
rleungx
pushed a commit
to rleungx/pd
that referenced
this issue
Dec 1, 2023
close tikv#6835 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-6.5
affects-6.6
affects-7.0
affects-7.1
affects-7.2
type/enhancement
The issue or PR belongs to an enhancement.
Enhancement Task
As we have observed, the
GetRegions
request will return information about all regions. If there are a large number of regions, it will occupy a significant amount of memory in a short period of time.Currently, we have found that after the connection is disconnected,
GetRegions
will continue to be processed and occupy a large amount of memory until it is completely handled before the memory is released.This is not a very good design, it will cause resource waste. We hope that after the connection is disconnected, PD can immediately stop processing requests and release resources.The text was updated successfully, but these errors were encountered: