-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix panic when using stores show limit #1807
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1807 +/- ##
==========================================
+ Coverage 77.95% 78.13% +0.17%
==========================================
Files 167 167
Lines 16468 16473 +5
==========================================
+ Hits 12838 12871 +33
+ Misses 2592 2562 -30
- Partials 1038 1040 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. do we need to add unit test about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@rleungx merge failed. |
/merge |
/run-all-tests |
cherry pick to release-3.0 in PR #1808 |
cherry pick to release-3.1 in PR #1809 |
What problem does this PR solve?
If we firstly use
stores remove-tombstone
and then callingstores show limit
inpd-ctl
. It will panic due to the nil pointer.What is changed and how it works?
This PR fixes it by removing the store limit when removing a tombstone store.
Check List
Tests
Related changes