-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client.go: Degrade log level when passing unavailable endpoint to client #1852
Conversation
when some endpoint passing into the client is unavailable in calling NewClient() will log the error log, but the service is supported to be still available if one of the endpoint can work. error level log will be too serious and confuse user.
Codecov Report
@@ Coverage Diff @@
## master #1852 +/- ##
=========================================
- Coverage 78.1% 78.01% -0.1%
=========================================
Files 168 168
Lines 17019 17019
=========================================
- Hits 13293 13277 -16
- Misses 2644 2654 +10
- Partials 1082 1088 +6
Continue to review full report at Codecov.
|
/run-all-tests |
@july2993 merge failed. |
/merge |
Your auto merge job has been accepted, waiting for 1851 |
/run-all-tests |
cherry pick to release-3.0 in PR #1856 |
cherry pick to release-2.1 failed |
cherry pick to release-3.1 in PR #1857 |
What problem does this PR solve?
when some endpoint passing into the client is unavailable
in calling NewClient() will log the error log, but the service is
supported to be still available if one of the endpoints can work.
error level log will be too serious and confuse the user.
What is changed and how it works?
client.go: Degrade log level when passing unavailable endpoint to client
Check List
Tests
log after this pr:
Code changes
Side effects
Related changes