-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: refine log in some packages (#2885) #2913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
added
component/log
Log.
require-LGT1
Indicates that the PR requires an LGTM.
status/LGT2
Indicates that a PR has LGTM 2.
type/cherry-pick
labels
Sep 7, 2020
rleungx
force-pushed
the
release-4.0-e352969cc4c4
branch
from
September 7, 2020 09:54
ec2cd74
to
ace48e7
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
release-4.0-e352969cc4c4
branch
from
September 7, 2020 09:56
ace48e7
to
4e80605
Compare
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2913 +/- ##
===============================================
- Coverage 77.34% 77.34% -0.01%
===============================================
Files 210 209 -1
Lines 22854 22847 -7
===============================================
- Hits 17676 17670 -6
+ Misses 3839 3834 -5
- Partials 1339 1343 +4
Continue to review full report at Codecov.
|
lhy1024
approved these changes
Sep 7, 2020
ti-srebot
added
status/LGT1
Indicates that a PR has LGTM 1.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Sep 7, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 7, 2020
/run-all-tests |
This was referenced Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/log
Log.
require-LGT1
Indicates that the PR requires an LGTM.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2885 to release-4.0
What problem does this PR solve?
Part of #2704.
What is changed and how it works?
This PR refines logs in some packages according to RFC.
Check List
Tests
Related changes
Release note