Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: set high priority for making up replicas (#2972) #2977

Merged
merged 2 commits into from
Sep 21, 2020
Merged

checker: set high priority for making up replicas (#2972) #2977

merged 2 commits into from
Sep 21, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2972 to release-4.0

What problem does this PR solve?

Making up replicas should be a high priority.

What is changed and how it works?

This PR sets the make-up-replica operator to high priority.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Set the make-up-replica operator to high priority

@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot ti-srebot added component/checker Checker logic. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 17, 2020
@ti-srebot ti-srebot added this to the v4.0.7 milestone Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #2977 into release-4.0 will increase coverage by 0.15%.
The diff coverage is 66.78%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2977      +/-   ##
===============================================
+ Coverage        77.16%   77.32%   +0.15%     
===============================================
  Files              204      209       +5     
  Lines            21940    22867     +927     
===============================================
+ Hits             16931    17682     +751     
- Misses            3724     3841     +117     
- Partials          1285     1344      +59
Impacted Files Coverage Δ
client/metrics.go 100.00% <ø> (ø)
pkg/apiutil/apiutil.go 67.34% <ø> (ø)
pkg/cache/cache.go 0.00% <ø> (ø)
pkg/cache/fifo.go 100.00% <ø> (ø)
pkg/cache/lru.go 80.35% <ø> (ø)
pkg/cache/two_queue.go 66.66% <ø> (ø)
pkg/codec/codec.go 78.57% <ø> (ø)
pkg/component/manager.go 81.01% <ø> (ø)
pkg/dashboard/adapter/redirector.go 94.23% <ø> (ø)
pkg/dashboard/keyvisual/input/core.go 33.33% <ø> (ø)
... and 205 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee41c4...9515cd5. Read the comment docs.

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 17, 2020
HunDunDM
HunDunDM approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2020
@rleungx
Copy link
Member

rleungx commented Sep 18, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Sep 21, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Sep 21, 2020

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@rleungx
Copy link
Member

rleungx commented Sep 21, 2020

/run-all-tests

@rleungx rleungx closed this Sep 21, 2020
@rleungx
cherry pick tikv#2972 to release-4.0
0e739ee 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx reopened this Sep 21, 2020
@rleungx
Copy link
Member

rleungx commented Sep 21, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2980
  • 2985
  • 2991
  • 2994
  • 2980

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 21, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2980
  • 2994
  • 2991
  • 2985

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 185d8c8 into tikv:release-4.0 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@disksing disksing Awaiting requested review from disksing

@nolouch nolouch Awaiting requested review from nolouch

Assignees

@rleungx rleungx

Labels
component/checker Checker logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @rleungx @lhy1024 @HunDunDM