-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: refine config clone #3116
Conversation
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM. Can you add unit test to verify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI failed due to |
Signed-off-by: Zheng Xiangsheng <hundundm@gmail.com>
/run-all-tests |
/merge |
/run-all-tests |
@HunDunDM merge failed. |
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #3120 |
What problem does this PR solve?
store-balance-rate
andtrace-region-flow
will be lost duringClone
.What is changed and how it works?
GetConfig
Check List
Related changes
Release note
trace-region-flow
will be accidentally changed tofalse
.