-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: return more replication info #4508
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4508 +/- ##
==========================================
+ Coverage 74.91% 74.95% +0.03%
==========================================
Files 265 265
Lines 27844 27851 +7
==========================================
+ Hits 20860 20875 +15
+ Misses 5121 5114 -7
+ Partials 1863 1862 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
close #4509 Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ad2195f
|
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Previously, only a boolean value is returned to indicate whether it is scheduled. But there are a lot of cases, when pd can not really make the schedule and waiting for something. A typical example is you ask for more replications than there is. And this requirement origins from pingcap/tidb#30960.
Close #4509
What is changed and how it works?
Now it returns a three-valued string.
Check List
Tests
Code changes
Release note