Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/core: add more benchmarks for region tree #4711

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Mar 7, 2022

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: ref #4455

What is changed and how it works?

server/core: add more benchmarks for region tree

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 7, 2022
@nolouch nolouch changed the title server/core: Add more benchmarks for region tree server/core: add more benchmarks for region tree Mar 7, 2022
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #4711 (0e2df0f) into master (2e22f1f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0e2df0f differs from pull request most recent head 64eda05. Consider uploading reports for the commit 64eda05 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4711      +/-   ##
==========================================
- Coverage   75.07%   75.06%   -0.02%     
==========================================
  Files         284      284              
  Lines       27901    27888      -13     
==========================================
- Hits        20947    20934      -13     
+ Misses       5089     5086       -3     
- Partials     1865     1868       +3     
Flag Coverage Δ
unittests 75.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
server/tso/tso.go 62.85% <0.00%> (-4.00%) ⬇️
server/storage/hot_region_storage.go 79.88% <0.00%> (-2.30%) ⬇️
server/api/region.go 67.17% <0.00%> (-2.03%) ⬇️
server/election/lease.go 86.15% <0.00%> (-1.54%) ⬇️
server/handler.go 51.22% <0.00%> (-1.42%) ⬇️
server/config/persist_options.go 92.85% <0.00%> (-0.76%) ⬇️
server/grpc_service.go 51.58% <0.00%> (-0.28%) ⬇️
server/schedulers/hot_region.go 83.38% <0.00%> (+0.30%) ⬆️
pkg/btree/btree.go 88.13% <0.00%> (+0.75%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e22f1f...64eda05. Read the comment docs.

Signed-off-by: nolouch <nolouch@gmail.com>
Copy link
Member

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@AndreMouche: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2022
@nolouch nolouch added type/feature-request Categorizes issue or PR as related to a new feature. require-LGT1 Indicates that the PR requires an LGTM. and removed type/feature-request Categorizes issue or PR as related to a new feature. labels Mar 9, 2022
@nolouch
Copy link
Contributor Author

nolouch commented Mar 9, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e2df0f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2022
@ti-chi-bot ti-chi-bot merged commit fb6ab7b into tikv:master Mar 9, 2022
@nolouch nolouch deleted the benchmark-regiontree branch March 9, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants