-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/core: add more benchmarks for region tree #4711
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
bafa424
to
d08d825
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
d08d825
to
b2fd746
Compare
Codecov Report
@@ Coverage Diff @@
## master #4711 +/- ##
==========================================
- Coverage 75.07% 75.06% -0.02%
==========================================
Files 284 284
Lines 27901 27888 -13
==========================================
- Hits 20947 20934 -13
+ Misses 5089 5086 -3
- Partials 1865 1868 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: nolouch <nolouch@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AndreMouche: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 0e2df0f
|
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Issue Number: ref #4455
What is changed and how it works?
Check List
Tests
Release note