Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move kv to pkg #5773

Merged
merged 2 commits into from
Dec 12, 2022
Merged

*: move kv to pkg #5773

merged 2 commits into from
Dec 12, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 12, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5838.

What is changed and how does it work?

This PR moves kv package from server to pkg so that tso logic won't rely on the server.

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 75.61% // Head: 75.65% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (2c728a4) compared to base (776003b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5773      +/-   ##
==========================================
+ Coverage   75.61%   75.65%   +0.04%     
==========================================
  Files         329      329              
  Lines       32965    32957       -8     
==========================================
+ Hits        24925    24933       +8     
+ Misses       5896     5882      -14     
+ Partials     2144     2142       -2     
Flag Coverage Δ
unittests 75.65% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/election/leadership.go 75.25% <ø> (ø)
pkg/storage/kv/etcd_kv.go 79.71% <ø> (ø)
pkg/storage/kv/levedb_kv.go 86.95% <ø> (ø)
pkg/storage/kv/mem_kv.go 100.00% <ø> (ø)
pkg/storage/kv/metrics.go 100.00% <ø> (ø)
server/config/store_config.go 81.60% <ø> (ø)
server/grpc_service.go 49.79% <ø> (+0.16%) ⬆️
server/id/id.go 86.44% <ø> (+3.38%) ⬆️
server/member/member.go 64.21% <ø> (-1.58%) ⬇️
server/region_syncer/history_buffer.go 78.46% <ø> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx requested review from nolouch and lhy1024 and removed request for JmPotato December 12, 2022 09:19
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 12, 2022
@nolouch
Copy link
Contributor

nolouch commented Dec 12, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 68ddc9a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 12, 2022
@ti-chi-bot ti-chi-bot merged commit 7ab1c9c into tikv:master Dec 12, 2022
@rleungx rleungx deleted the remove-kv branch December 12, 2022 10:07
Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants