client: fix compatibility problem of pd client (#6244) #6245
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
VelocityLight
added
the
cherry-pick-approved
ti-chi-bot
added
status/LGT2
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 1802a2e
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-7.0 #6245 +/- ##
===============================================
- Coverage 74.69% 74.55% -0.14%
===============================================
Files 394 394
Lines 38760 38763 +3
===============================================
- Hits 28950 28901 -49
- Misses 7276 7303 +27
- Partials 2534 2559 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| if err != nil { | ||
| log.Warn("[pd] failed to get cluster info for the leader", zap.String("leader-addr", leaderAddr), errs.ZapError(err)) | ||
| // TODO: it's a hack way to solve the compatibility issue. |
There was a problem hiding this comment.
Probably we need to add service mode to the every rpc response from the pd/api and handle it gracefully.
VelocityLight
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
VelocityLight
added
cherry-pick-approved
This is an automated cherry-pick of #6244
What problem does this PR solve?
Issue Number: Close #6243.
What is changed and how does it work?
Check List
Tests
By using tiup playground:
tiup playground v6.6.0 --db 1 --pd 3 --kv 4 --tiflash 0 --host 172.16.4.3and replace the tidb binary with the fixed one.Release note