Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix the gctuner tests #6330

Merged
merged 6 commits into from
Aug 7, 2024
Merged

*: fix the gctuner tests #6330

merged 6 commits into from
Aug 7, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 18, 2023

What problem does this PR solve?

Issue Number: Close #5953.

What is changed and how does it work?

Enable all gctuner-related tests.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.45%. Comparing base (7ef2be0) to head (c05c0f8).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6330      +/-   ##
==========================================
+ Coverage   77.34%   77.45%   +0.10%     
==========================================
  Files         472      472              
  Lines       61796    61796              
==========================================
+ Hits        47799    47866      +67     
+ Misses      10433    10376      -57     
+ Partials     3564     3554      -10
Flag Coverage Δ
unittests 77.45% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024
Copy link
Contributor

lhy1024 commented Apr 19, 2023

still failed

--- FAIL: TestTuner (1.35s)
    tuner_test.go:59: 
        	Error Trace:	/home/runner/work/pd/pd/pkg/gctuner/tuner_test.go:59
        	Error:      	Condition never satisfied
        	Test:       	TestTuner

bufferflies
bufferflies reviewed Apr 21, 2023
View reviewed changes
pkg/gctuner/finalizer_test.go
@@ -39,6 +38,7 @@ func TestFinalizer(t *testing.T) {
})
for i := int32(1); i <= maxCount; i++ {
runtime.GC()
time.Sleep(10 * time.Millisecond)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It maybe unstable, how about use channel or signal?

bufferflies
bufferflies reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 14, 2023
@rleungx
fix the gctuner tests
c0c1e0f 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
address the comment
c6d110e 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
resolve conflicts
b6d2526 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Jul 23, 2024

/test ?

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 23, 2024

@rleungx: The following commands are available to trigger required jobs:

  • /test build

The following commands are available to trigger optional jobs:

  • /test pull-integration-copr-test
  • /test pull-integration-realcluster-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build
  • tikv/pd/pull_integration_realcluster_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx
Copy link
Member Author

rleungx commented Jul 23, 2024

/test all

@rleungx
Copy link
Member Author

rleungx commented Jul 23, 2024

/test pull-integration-realcluster-test

@rleungx
Copy link
Member Author

rleungx commented Aug 6, 2024

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-07 07:24:05.136469532 +0000 UTC m=+423175.003568621: ☑️ agreed by JmPotato.
  • 2024-08-07 07:33:29.140886443 +0000 UTC m=+423739.007985530: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit ccf8d66 into tikv:master Aug 7, 2024
25 checks passed
@rleungx rleungx deleted the fix-gctuner branch August 7, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies left review comments

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
approved dco-signoff: yes lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*: make test is failed about cgroup
5 participants
@rleungx @ti-chi-bot @lhy1024 @JmPotato @bufferflies