minResolvedTS: Provide an API to fetch the store resolved_ts #6413

HuSharp · 2023-05-08T03:15:42Z

What problem does this PR solve?

Issue Number: Close #6386

What is changed and how does it work?

Provide an API to fetch the store resolved_ts

Check List

Tests

Unit test

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot · 2023-05-08T03:15:44Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-05-08T03:15:44Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: husharp <jinhao.hu@pingcap.com>

codecov · 2023-05-08T03:39:18Z

Codecov Report

Patch coverage: 5.26% and project coverage change: +0.02 🎉

Comparison is base (f539d33) 75.15% compared to head (23d630e) 75.17%.

❗ Current head 23d630e differs from pull request most recent head 42ef3af. Consider uploading reports for the commit 42ef3af to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6413      +/-   ##
==========================================
+ Coverage   75.15%   75.17%   +0.02%     
==========================================
  Files         408      408              
  Lines       41247    41164      -83     
==========================================
- Hits        30999    30945      -54     
+ Misses       7578     7542      -36     
- Partials     2670     2677       +7

Flag	Coverage Δ
unittests	`75.17% <5.26%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/api/min_resolved_ts.go	`45.83% <0.00%> (-54.17%)`	⬇️
server/cluster/cluster.go	`81.58% <0.00%> (+0.07%)`	⬆️
server/api/router.go	`97.98% <100.00%> (+<0.01%)`	⬆️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

JmPotato · 2023-05-08T04:02:04Z

server/cluster/cluster.go

+func (c *RaftCluster) GetStoreMinResolvedTS(storeID uint64) uint64 {
+	c.RLock()
+	defer c.RUnlock()
+	if !c.isInitialized() {


Do we also need to check IsAvailableForMinResolvedTS here?

Signed-off-by: husharp <jinhao.hu@pingcap.com>

JmPotato · 2023-05-09T05:58:11Z

/merge

ti-chi-bot · 2023-05-09T05:58:12Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-05-09T05:58:13Z

This pull request has been accepted and is ready to merge.

Commit hash: 23d630e

close tikv#6386 Provide an API to fetch the store resolved_ts Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: zeminzhou <zhouzemin@pingcap.com>

JmPotato · 2023-05-25T10:03:28Z

/cherry-pick release-7.1

ti-chi-bot · 2023-05-25T10:04:04Z

@JmPotato: new pull request created to branch release-7.1: #6521.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

JmPotato · 2023-05-25T10:04:20Z

/cherry-pick release-6.5

ti-chi-bot · 2023-05-25T10:04:39Z

In response to a cherrypick label: new pull request created to branch release-6.5: #6522.

ti-chi-bot · 2023-05-25T10:04:40Z

In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/pd#release-7.1 from head ti-chi-bot:cherry-pick-6413-to-release-7.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-6413-to-release-7.1."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

close tikv#6386 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2023-05-25T10:05:16Z

@JmPotato: new pull request could not be created: failed to create pull request against tikv/pd#release-6.5 from head ti-chi-bot:cherry-pick-6413-to-release-6.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-6413-to-release-6.5."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close tikv#6386 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

…6521) close #6386, ref #6413 Provide an API to fetch the store resolved_ts Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: husharp <jinhao.hu@pingcap.com>

…6522) close #6386, ref #6413 Provide an API to fetch the store resolved_ts Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: Hu# <jinhao.hu@pingcap.com>

update

5f8a363

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels May 8, 2023

ti-chi-bot bot requested review from disksing and rleungx May 8, 2023 03:15

update

e21f695

Signed-off-by: husharp <jinhao.hu@pingcap.com>

JmPotato reviewed May 8, 2023

View reviewed changes

update

23d630e

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp marked this pull request as ready for review May 8, 2023 07:11

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023

lhy1024 approved these changes May 9, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2023

JmPotato approved these changes May 9, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2023

Merge branch 'master' into add_store_min_resolved_ts

42ef3af

ti-chi-bot bot merged commit 4ad5c48 into tikv:master May 9, 2023

HuSharp deleted the add_store_min_resolved_ts branch May 9, 2023 06:41

HuSharp mentioned this pull request May 11, 2023

pd http: support api to get store min resolved ts tikv/client-go#793

Merged

JmPotato added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 25, 2023

ti-chi-bot mentioned this pull request May 25, 2023

minResolvedTS: Provide an API to fetch the store resolved_ts (#6413) #6521

Merged

ti-chi-bot mentioned this pull request May 25, 2023

minResolvedTS: Provide an API to fetch the store resolved_ts (#6413) #6522

Merged

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 25, 2023

This is an automated cherry-pick of tikv#6413

86ba412

close tikv#6386 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 25, 2023

This is an automated cherry-pick of tikv#6413

51f4463

close tikv#6386 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minResolvedTS: Provide an API to fetch the store resolved_ts #6413

minResolvedTS: Provide an API to fetch the store resolved_ts #6413

HuSharp commented May 8, 2023

ti-chi-bot bot commented May 8, 2023 •

edited

Loading

ti-chi-bot bot commented May 8, 2023

codecov bot commented May 8, 2023 •

edited

Loading

JmPotato May 8, 2023

HuSharp May 8, 2023

JmPotato commented May 9, 2023

ti-chi-bot bot commented May 9, 2023

ti-chi-bot bot commented May 9, 2023

JmPotato commented May 25, 2023

ti-chi-bot commented May 25, 2023

JmPotato commented May 25, 2023

ti-chi-bot commented May 25, 2023

ti-chi-bot commented May 25, 2023

ti-chi-bot commented May 25, 2023

minResolvedTS: Provide an API to fetch the store resolved_ts #6413

minResolvedTS: Provide an API to fetch the store resolved_ts #6413

Conversation

HuSharp commented May 8, 2023

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented May 8, 2023 • edited Loading

ti-chi-bot bot commented May 8, 2023

codecov bot commented May 8, 2023 • edited Loading

Codecov Report

JmPotato May 8, 2023

Choose a reason for hiding this comment

HuSharp May 8, 2023

Choose a reason for hiding this comment

JmPotato commented May 9, 2023

ti-chi-bot bot commented May 9, 2023

ti-chi-bot bot commented May 9, 2023

JmPotato commented May 25, 2023

ti-chi-bot commented May 25, 2023

JmPotato commented May 25, 2023

ti-chi-bot commented May 25, 2023

ti-chi-bot commented May 25, 2023

ti-chi-bot commented May 25, 2023

ti-chi-bot bot commented May 8, 2023 •

edited

Loading

codecov bot commented May 8, 2023 •

edited

Loading