resource_manager/client: modify log level #6450

CabinfeverB · 2023-05-12T02:13:49Z

What problem does this PR solve?

Issue Number: ref #4399 close #6495

What is changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot · 2023-05-12T02:13:51Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2023-05-12T02:26:09Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.28 🎉

Comparison is base (511115f) 74.86% compared to head (44c39ea) 75.15%.

❗ Current head 44c39ea differs from pull request most recent head 4471de1. Consider uploading reports for the commit 4471de1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
+ Coverage   74.86%   75.15%   +0.28%     
==========================================
  Files         410      409       -1     
  Lines       41682    41493     -189     
==========================================
- Hits        31206    31182      -24     
+ Misses       7768     7617     -151     
+ Partials     2708     2694      -14

Flag	Coverage Δ
unittests	`75.15% <100.00%> (+0.28%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
client/resource_group/controller/limiter.go	`72.06% <100.00%> (ø)`

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rleungx · 2023-05-12T03:09:20Z

client/resource_group/controller/limiter.go

@@ -371,7 +371,7 @@ func (lim *Limiter) reserveN(now time.Time, n float64, maxFutureReserve time.Dur
 		lim.tokens = tokens
 		lim.maybeNotify()
 	} else {
-		log.Warn("[resource group controller]", zap.Float64("NewTokens", lim.tokens), zap.Float64("current rate", float64(lim.limit)), zap.Float64("request tokens", n), zap.Int64("burst", lim.burst), zap.Int("remaining notify times", lim.remainingNotifyTimes))
+		log.Debug("[resource group controller]", zap.Float64("Tokens", lim.tokens), zap.Float64("current rate", float64(lim.limit)), zap.Float64("request tokens", n), zap.Int64("burst", lim.burst), zap.Int("remaining notify times", lim.remainingNotifyTimes))


How about using - to link the words.

@CabinfeverB Can u also update this line? :) https://github.com/tikv/pd/blob/master/pkg/mcs/resource_manager/server/grpc_service.go#L217

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2023-05-12T10:23:06Z

/merge

ti-chi-bot · 2023-05-12T10:23:07Z

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-05-12T10:23:09Z

This pull request has been accepted and is ready to merge.

Commit hash: b4c3279

ti-chi-bot · 2023-05-12T10:46:32Z

@CabinfeverB: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-05-19T10:16:37Z

In response to a cherrypick label: new pull request created to branch release-7.1: #6497.

ref #4399, ref #6450, close #6495 Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: Cabinfever_B <cabinfeveroier@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

modify log version

28e84aa

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 12, 2023

ti-chi-bot bot requested review from nolouch and rleungx May 12, 2023 02:13

rleungx reviewed May 12, 2023

View reviewed changes

modify log level

44c39ea

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

rleungx approved these changes May 12, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2023

address comment

b4c3279

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

nolouch approved these changes May 12, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023

ti-chi-bot bot added 3 commits May 12, 2023 10:23

Merge branch 'master' into resource_manager/fix

ce03002

Merge branch 'master' into resource_manager/fix

9fbfaea

Merge branch 'master' into resource_manager/fix

4471de1

ti-chi-bot bot merged commit 6ce20fe into tikv:master May 12, 2023

CabinfeverB added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label May 19, 2023

ti-chi-bot mentioned this pull request May 19, 2023

resource_manager/client: modify log level (#6450) #6497

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource_manager/client: modify log level #6450

resource_manager/client: modify log level #6450

CabinfeverB commented May 12, 2023 •

edited

Loading

ti-chi-bot bot commented May 12, 2023 •

edited

Loading

codecov bot commented May 12, 2023 •

edited

Loading

rleungx May 12, 2023

HuSharp May 12, 2023

CabinfeverB commented May 12, 2023

ti-chi-bot bot commented May 12, 2023

ti-chi-bot bot commented May 12, 2023

ti-chi-bot bot commented May 12, 2023

ti-chi-bot commented May 19, 2023

resource_manager/client: modify log level #6450

resource_manager/client: modify log level #6450

Conversation

CabinfeverB commented May 12, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented May 12, 2023 • edited Loading

codecov bot commented May 12, 2023 • edited Loading

Codecov Report

rleungx May 12, 2023

Choose a reason for hiding this comment

HuSharp May 12, 2023

Choose a reason for hiding this comment

CabinfeverB commented May 12, 2023

ti-chi-bot bot commented May 12, 2023

ti-chi-bot bot commented May 12, 2023

ti-chi-bot bot commented May 12, 2023

ti-chi-bot commented May 19, 2023

CabinfeverB commented May 12, 2023 •

edited

Loading

ti-chi-bot bot commented May 12, 2023 •

edited

Loading

codecov bot commented May 12, 2023 •

edited

Loading