-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyspace: update keyspace config TSOKeyspaceGroupIDKey during the split #6578
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
m.km.metaLock.Unlock(id) | ||
} | ||
}() | ||
for _, keyspace := range keyspaces { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SaveKeyspaceMeta() needs to be called in batches too, otherwise the len(keyspaces) in a split needs to be <= maxTxnOps which isn't practical even in dev with tens thousands of keyspaces. Adding batching in another place increases complexity again.
Let's discuss about it today. @rleungx
Close since the flag |
What problem does this PR solve?
Issue Number: ref #6232.
What is changed and how does it work?
Check List
Tests
Release note