Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication mode: tune persist file timeout #6670

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jun 25, 2023

Issue Number: Fix #6672

cherry-pick #6669

What is changed and how does it work?

change persist file timeout from 10s to 3s to speed up state change

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the status/DNM Do not merge this PR. label Jun 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jun 25, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx June 25, 2023 08:25
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.45 🎉

Comparison is base (086871d) 75.59% compared to head (379a9e0) 76.05%.

❗ Current head 379a9e0 differs from pull request most recent head 5fa2e72. Consider uploading reports for the commit 5fa2e72 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6670      +/-   ##
===============================================
+ Coverage        75.59%   76.05%   +0.45%     
===============================================
  Files              329      330       +1     
  Lines            33130    33525     +395     
===============================================
+ Hits             25046    25498     +452     
+ Misses            5931     5874      -57     
  Partials          2153     2153              
Flag Coverage Δ
unittests 76.05% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/replication/replication_mode.go 78.94% <ø> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@disksing disksing removed the status/DNM Do not merge this PR. label Jun 26, 2023
@disksing disksing requested a review from nolouch June 26, 2023 01:35
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 11, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 11, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 11, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 379a9e0

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 11, 2023
@nolouch nolouch closed this Jul 12, 2023
@nolouch nolouch reopened this Jul 12, 2023
@nolouch
Copy link
Contributor

nolouch commented Jul 12, 2023

@disksing out-of-date, may need push some new commit.

@ti-chi-bot ti-chi-bot bot merged commit bd94a98 into tikv:release-6.5 Jul 14, 2023
15 checks passed
@disksing disksing deleted the disksing/timeout2 branch July 14, 2023 03:26
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 1, 2024
fix tikv#6672

Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants