member: avoid frequent campaign times #7301

HuSharp · 2023-11-02T08:01:58Z

What problem does this PR solve?

Issue Number: Close #7251, ref #7377

What is changed and how does it work?

when pd leader frequently campaign leader, but etcd leader did not change.
We need to prevent this pd leader campaign and resign to another member.

Check List

Tests

Unit test

Release note

None.

ti-chi-bot · 2023-11-02T08:02:01Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

bufferflies
lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

HuSharp · 2023-11-02T08:04:58Z

pkg/mcs/resourcemanager/server/server.go

@@ -152,7 +152,7 @@ func (s *Server) primaryElectionLoop() {

 func (s *Server) campaignLeader() {
 	log.Info("start to campaign the primary/leader", zap.String("campaign-resource-manager-primary-name", s.participant.Name()))
-	if err := s.participant.CampaignLeader(s.cfg.LeaderLease); err != nil {
+	if err := s.participant.CampaignLeader(s.Context(), s.cfg.LeaderLease); err != nil {


FYI, pass context to make sure resign can be used

Signed-off-by: husharp <jinhao.hu@pingcap.com>

codecov · 2023-11-02T08:31:21Z

Codecov Report

Merging #7301 (8f141b2) into master (181fdc9) will decrease coverage by 0.04%.
The diff coverage is 80.95%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
- Coverage   74.35%   74.31%   -0.04%     
==========================================
  Files         451      451              
  Lines       48863    48877      +14     
==========================================
- Hits        36330    36325       -5     
- Misses       9324     9336      +12     
- Partials     3209     3216       +7

Flag	Coverage Δ
unittests	`74.31% <80.95%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024 · 2023-11-02T09:23:22Z

pkg/election/leadership.go

@@ -105,7 +109,8 @@ func (ls *Leadership) GetLeaderKey() string {
 }

 // Campaign is used to campaign the leader with given lease and returns a leadership
-func (ls *Leadership) Campaign(leaseTimeout int64, leaderData string, cmps ...clientv3.Cmp) error {
+func (ls *Leadership) Campaign(ctx context.Context, leaseTimeout int64, leaderData string, cmps ...clientv3.Cmp) error {
+	ls.CampaignTimes = append(ls.CampaignTimes, *cache.NewStringTTL(ctx, 5*time.Second, 5*time.Minute))


Is its length always increase?

replace to slice without ttl

pkg/encryption/key_manager_test.go

bufferflies · 2023-11-02T09:28:48Z

pkg/election/leadership.go

@@ -62,6 +63,9 @@ type Leadership struct {
 	keepAliveCtx            context.Context
 	keepAliveCancelFunc     context.CancelFunc
 	keepAliveCancelFuncLock syncutil.Mutex
+	// CampaignTimes is used to record the campaign times of the leader in 5min.
+	// To avoid the leader campaign too frequently.
+	CampaignTimes []cache.TTLString


TTLString is container, no needs to use array.BTW, you can only use array not ttlcache.

good catch. fixed

Signed-off-by: husharp <jinhao.hu@pingcap.com>

pkg/election/leadership.go

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-11-13T07:24:02Z

Being tested on tcms... please DO NOT merge in now :)

rleungx · 2023-11-13T07:50:49Z

/hold

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-11-15T04:58:54Z

after test, we can reduce the duration for qps drop to zero

before

after

HuSharp · 2023-11-15T04:59:08Z

/unhold

bufferflies · 2023-11-16T01:58:21Z

/merge

ti-chi-bot · 2023-11-16T01:58:23Z

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-11-16T01:58:25Z

This pull request has been accepted and is ready to merge.

Commit hash: bacc30a

ti-chi-bot · 2023-11-16T01:58:38Z

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-02-01T09:26:48Z

/cherry-pick release-7.5

ti-chi-bot · 2024-02-01T09:27:24Z

In response to a cherrypick label: new pull request created to branch release-7.5: #7790.

ti-chi-bot · 2024-02-01T09:27:59Z

@ti-chi-bot: new pull request could not be created: failed to create pull request against tikv/pd#release-7.5 from head ti-chi-bot:cherry-pick-7301-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-7301-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #7251, ref #7377 when pd leader frequently campaign leader, but etcd leader did not change. We need to prevent this pd leader campaign and resign to another member. Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 2, 2023

HuSharp requested review from lhy1024 and bufferflies November 2, 2023 08:02

ti-chi-bot bot requested a review from rleungx November 2, 2023 08:02

ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2023

HuSharp commented Nov 2, 2023

View reviewed changes

HuSharp force-pushed the avoid_campaign_leader branch from 05e25f3 to eaecc64 Compare November 2, 2023 08:08

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2023

fix

a16c1c9

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the avoid_campaign_leader branch from eaecc64 to a16c1c9 Compare November 2, 2023 08:17

lhy1024 reviewed Nov 2, 2023

View reviewed changes

bufferflies reviewed Nov 2, 2023

View reviewed changes

HuSharp force-pushed the avoid_campaign_leader branch from 91d410c to 99db858 Compare November 2, 2023 09:53

HuSharp changed the title ~~member: avoid frequency campaign times~~ member: avoid frequent campaign times Nov 3, 2023

fix

7ccde6b

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the avoid_campaign_leader branch from 99db858 to 7ccde6b Compare November 3, 2023 05:17

bufferflies approved these changes Nov 3, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2023

lhy1024 reviewed Nov 13, 2023

View reviewed changes

pkg/election/leadership.go Outdated Show resolved Hide resolved

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Nov 13, 2023

add const and modify annotation

0b032cc

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the avoid_campaign_leader branch from fcc8695 to 0b032cc Compare November 13, 2023 05:05

lhy1024 approved these changes Nov 13, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 13, 2023

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023

add test

bacc30a

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the avoid_campaign_leader branch from 880d627 to bacc30a Compare November 14, 2023 07:26

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2023

Merge branch 'master' into avoid_campaign_leader

8f141b2

ti-chi-bot bot merged commit 0ebf4b2 into tikv:master Nov 16, 2023
26 checks passed

HuSharp deleted the avoid_campaign_leader branch November 16, 2023 02:38

This was referenced Nov 16, 2023

TestMicroserviceTSOClient/TestUpdateAfterResetTSO is unstable #7381

Closed

*: make resign leader test more stable #7402

Merged

bufferflies mentioned this pull request Jan 9, 2024

Improving system high availability when the disk experiences jitter. #7377

Open

ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 1, 2024

ti-chi-bot mentioned this pull request Feb 1, 2024

member: avoid frequent campaign times (#7301) #7790

Merged

ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 2, 2024

JmPotato mentioned this pull request Sep 4, 2024

qps drop more than 2 mins and also affect pitr and cdc lag when injection pd leader io delay 500ms or 1s or io hang due to a circuit breaker mechanism which is by design #8594

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

member: avoid frequent campaign times #7301

member: avoid frequent campaign times #7301

HuSharp commented Nov 2, 2023 •

edited by bufferflies

Loading

ti-chi-bot bot commented Nov 2, 2023 •

edited

Loading

HuSharp Nov 2, 2023 •

edited

Loading

codecov bot commented Nov 2, 2023 •

edited

Loading

lhy1024 Nov 2, 2023

HuSharp Nov 2, 2023

bufferflies Nov 2, 2023

HuSharp Nov 2, 2023

HuSharp commented Nov 13, 2023

rleungx commented Nov 13, 2023

HuSharp commented Nov 15, 2023

HuSharp commented Nov 15, 2023

bufferflies commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot commented Feb 1, 2024

ti-chi-bot commented Feb 1, 2024

ti-chi-bot commented Feb 1, 2024

member: avoid frequent campaign times #7301

member: avoid frequent campaign times #7301

Conversation

HuSharp commented Nov 2, 2023 • edited by bufferflies Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Nov 2, 2023 • edited Loading

HuSharp Nov 2, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Nov 2, 2023 • edited Loading

Codecov Report

lhy1024 Nov 2, 2023

Choose a reason for hiding this comment

HuSharp Nov 2, 2023

Choose a reason for hiding this comment

bufferflies Nov 2, 2023

Choose a reason for hiding this comment

HuSharp Nov 2, 2023

Choose a reason for hiding this comment

HuSharp commented Nov 13, 2023

rleungx commented Nov 13, 2023

HuSharp commented Nov 15, 2023

HuSharp commented Nov 15, 2023

bufferflies commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot bot commented Nov 16, 2023

ti-chi-bot commented Feb 1, 2024

ti-chi-bot commented Feb 1, 2024

ti-chi-bot commented Feb 1, 2024

HuSharp commented Nov 2, 2023 •

edited by bufferflies

Loading

ti-chi-bot bot commented Nov 2, 2023 •

edited

Loading

HuSharp Nov 2, 2023 •

edited

Loading

codecov bot commented Nov 2, 2023 •

edited

Loading