Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Pass TLS info to dashboard to fix TiKV heap profiling #7563

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

Connor1996
Copy link
Member

What problem does this PR solve?

Issue Number: Close #7561

What is changed and how does it work?

Pass TLS info to dashboard to fix TiKV heap profiling

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2023
@mornyx
Copy link
Contributor

mornyx commented Dec 18, 2023

Please also update dependencies in tests/integrations (as https://github.com/tikv/pd/pull/7458/files did).

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Dec 19, 2023
@CabinfeverB
Copy link
Member

Also for /tests/integrations/realtiup

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996
Copy link
Member Author

PTAL @CabinfeverB @mornyx

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #7563 (1743ff6) into master (25f48f0) will decrease coverage by 0.04%.
The diff coverage is 68.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7563      +/-   ##
==========================================
- Coverage   74.84%   74.80%   -0.04%     
==========================================
  Files         457      457              
  Lines       50343    50351       +8     
==========================================
- Hits        37677    37667      -10     
- Misses       9341     9359      +18     
  Partials     3325     3325              
Flag Coverage Δ
unittests 74.80% <68.75%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 19, 2023
@Connor1996
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1743ff6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot merged commit 83da4c2 into tikv:master Dec 19, 2023
24 of 26 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #7575.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 19, 2023
close tikv#7561

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@baurine
Copy link
Contributor

baurine commented Dec 29, 2023

This tidb-dashboard release has a bug that will cause manual profiling page show white screen, will fix in next tidb-dashboard releasse.

baurine pushed a commit to baurine/pd that referenced this pull request Feb 19, 2024
…v#7563)

close tikv#7561

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
baurine pushed a commit to baurine/pd that referenced this pull request Feb 28, 2024
…v#7563)

close tikv#7561

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7857.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 28, 2024
close tikv#7561

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
baurine added a commit to baurine/pd that referenced this pull request Mar 27, 2024
…v#7563)

close tikv#7561

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: baurine <2008.hbl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard tikv heap profiling failed when tls enabled
6 participants