-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard: Pass TLS info to dashboard to fix TiKV heap profiling #7563
Conversation
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please also update dependencies in |
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Also for /tests/integrations/realtiup |
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
PTAL @CabinfeverB @mornyx |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7563 +/- ##
==========================================
- Coverage 74.84% 74.80% -0.04%
==========================================
Files 457 457
Lines 50343 50351 +8
==========================================
- Hits 37677 37667 -10
- Misses 9341 9359 +18
Partials 3325 3325
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1743ff6
|
In response to a cherrypick label: new pull request created to branch |
close tikv#7561 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This tidb-dashboard release has a bug that will cause manual profiling page show white screen, will fix in next tidb-dashboard releasse. |
In response to a cherrypick label: new pull request created to branch |
close tikv#7561 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: Close #7561
What is changed and how does it work?
Check List
Tests
Related changes
Release note