Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: support tls and refactor #7745

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 22, 2024

What problem does this PR solve?

Issue Number: Ref #7703.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and nolouch January 22, 2024 11:16
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #7745 (fc448d4) into master (1a38582) will increase coverage by 4.57%.
The diff coverage is n/a.

❗ Current head fc448d4 differs from pull request most recent head 886b3bf. Consider uploading reports for the commit 886b3bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7745      +/-   ##
==========================================
+ Coverage   69.24%   73.81%   +4.57%     
==========================================
  Files         430      430              
  Lines       47641    47625      -16     
==========================================
+ Hits        32987    35154    +2167     
+ Misses      11936     9487    -2449     
- Partials     2718     2984     +266     
Flag Coverage Δ
unittests 73.81% <ø> (+4.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

for _, region := range updatedRegionsMap {
for _, i := range reportRegions {
region := rs.regions[i]
if r, exist := updatedRegionsMap[i]; exist {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do L306-L308 mean

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace by the region which is updated above

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 24, 2024
@CabinfeverB CabinfeverB added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 24, 2024
@rleungx
Copy link
Member Author

rleungx commented Jan 24, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 0634288

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ca8fd3d into tikv:master Jan 24, 2024
22 checks passed
@rleungx rleungx deleted the update-hb-bench branch January 25, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants