Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: putting tools tests in a separate chunk #7800

Merged
merged 14 commits into from
Feb 6, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Feb 4, 2024

What problem does this PR solve?

Issue Number: Close #7805 Close #7609

What is changed and how does it work?

because

packages=($(go list ./...))
not contains tools after tools has own go mod

we can put tools tests in a separate chunk

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Feb 4, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Feb 4, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2024
@HuSharp HuSharp force-pushed the fix_tools_ci_tests branch 6 times, most recently from a32f442 to 3724699 Compare February 4, 2024 05:50
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2024
@HuSharp HuSharp changed the title ci: fix tools ci ci: putting tools tests in a separate chunk Feb 4, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 5, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 5, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #7800 (bd804d3) into master (37be34e) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7800      +/-   ##
==========================================
+ Coverage   73.47%   73.52%   +0.05%     
==========================================
  Files         432      432              
  Lines       47842    47842              
==========================================
+ Hits        35151    35177      +26     
+ Misses       9648     9636      -12     
+ Partials     3043     3029      -14     
Flag Coverage Δ
unittests 73.52% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 5, 2024
@HuSharp HuSharp requested a review from JmPotato February 5, 2024 10:10
scripts/ci-subtask.sh Show resolved Hide resolved
tools/pd-ctl/tests/config/config_test.go Outdated Show resolved Hide resolved
tools/pd-ctl/tests/config/config_test.go Outdated Show resolved Hide resolved
tools/pd-ctl/tests/config/config_test.go Outdated Show resolved Hide resolved
tools/pd-ctl/tests/tso/tso_test.go Show resolved Hide resolved
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
tools/Makefile Outdated

failpoint-enable:
cd $(ROOT_PATH) && $(MAKE) failpoint-enable
go mod tidy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need go mod tidy here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy from another Makefile... seems like assume It's possible that enabling these failpoints might also involve adding dependencies which need go mod tidy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hypothesis doesn't seem to exist for the moment, so let's remove it for now

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 6, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Feb 6, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 6, 2024

This pull request has been accepted and is ready to merge.

Commit hash: bd804d3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0419004 into tikv:master Feb 6, 2024
24 of 26 checks passed
@HuSharp HuSharp deleted the fix_tools_ci_tests branch February 6, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: putting tools tests in a separate chunk TestSchedulerDiagnostic is unstable
4 participants