-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: putting tools tests in a separate chunk #7800
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
c598840
to
b65e069
Compare
a32f442
to
3724699
Compare
e35d306
to
b2a54e5
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
b2a54e5
to
dfe8be2
Compare
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7800 +/- ##
==========================================
+ Coverage 73.47% 73.52% +0.05%
==========================================
Files 432 432
Lines 47842 47842
==========================================
+ Hits 35151 35177 +26
+ Misses 9648 9636 -12
+ Partials 3043 3029 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
tools/Makefile
Outdated
|
||
failpoint-enable: | ||
cd $(ROOT_PATH) && $(MAKE) failpoint-enable | ||
go mod tidy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need go mod tidy here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy from another Makefile... seems like assume It's possible that enabling these failpoints might also involve adding dependencies which need go mod tidy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hypothesis doesn't seem to exist for the moment, so let's remove it for now
Signed-off-by: husharp <jinhao.hu@pingcap.com>
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: bd804d3
|
What problem does this PR solve?
Issue Number: Close #7805 Close #7609
What is changed and how does it work?
because
pd/scripts/ci-subtask.sh
Line 29 in 93f89f1
we can put tools tests in a separate chunk
Check List
Tests
Release note