Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: record the max RU per second (#7936) #7968

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7936

What problem does this PR solve?

Issue Number: Close #7908

When I only run workload A:

sysbench --mysql-user=user1 --mysql-host=10.2.12.53 --mysql-port=32335 --table-size=10000000  oltp_read_only run --time=1000 --report-interval=1 --threads=4  --mysql-db=test --tables=32 --rate=2

RU Avg is OK because the workload is stable.
image

But When I manually run the big query SQL like:

select count(*) from test.sbtest1;

The monitoring was not very accurate(on-avg), which led me to mistakenly believe that I was far away from triggering RC control.
image

But from the slow query:
image
it cost 8000+ RU, and which let some query need wait in the RC queue

What is changed and how does it work?

resource_manager: record the max RU per second 

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #7968 (e66679f) into release-7.5 (8783927) will increase coverage by 0.00%.
Report is 2 commits behind head on release-7.5.
The diff coverage is 94.00%.

❗ Current head e66679f differs from pull request most recent head bb658c8. Consider uploading reports for the commit bb658c8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           release-7.5    #7968   +/-   ##
============================================
  Coverage        74.51%   74.52%           
============================================
  Files              444      444           
  Lines            48156    48203   +47     
============================================
+ Hits             35883    35921   +38     
- Misses            9079     9084    +5     
- Partials          3194     3198    +4     
Flag Coverage Δ
unittests 74.52% <94.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 1, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

This pull request has been accepted and is ready to merge.

Commit hash: e66679f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5845336 into tikv:release-7.5 Apr 3, 2024
19 checks passed
@HuSharp HuSharp deleted the cherry-pick-7936-to-release-7.5 branch April 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants