-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_manager: record the max RU per second (#7936) #7968
resource_manager: record the max RU per second (#7936) #7968
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #7968 +/- ##
============================================
Coverage 74.51% 74.52%
============================================
Files 444 444
Lines 48156 48203 +47
============================================
+ Hits 35883 35921 +38
- Misses 9079 9084 +5
- Partials 3194 3198 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e66679f
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #7936
What problem does this PR solve?
Issue Number: Close #7908
When I only run workload A:
RU Avg is OK because the workload is stable.
But When I manually run the big query SQL like:
The monitoring was not very accurate(on-avg), which led me to mistakenly believe that I was far away from triggering RC control.
But from the slow query:
it cost 8000+ RU, and which let some query need wait in the RC queue
What is changed and how does it work?
Check List
Tests
Release note