Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix trace-region-flow displayed incorrectly #7993

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 28, 2024

What problem does this PR solve?

Issue Number: Close #7917.

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Manual test

After this PR:

mysql> show config where name like "%pd-server.trace-region-flow%";
Empty set (0.01 sec)

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 28, 2024
@ti-chi-bot ti-chi-bot bot requested review from disksing and JmPotato March 28, 2024 03:42
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #7993 (69593bb) into master (2c20897) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 69593bb differs from pull request most recent head c90b783. Consider uploading reports for the commit c90b783 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7993      +/-   ##
==========================================
+ Coverage   73.60%   73.66%   +0.06%     
==========================================
  Files         436      436              
  Lines       48476    48474       -2     
==========================================
+ Hits        35679    35707      +28     
+ Misses       9739     9716      -23     
+ Partials     3058     3051       -7     
Flag Coverage Δ
unittests 73.66% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from nolouch and removed request for disksing March 28, 2024 06:44
@rleungx rleungx changed the title config: hide trace-region-flow config: fix trace-region-flow displayed incorrectly Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Mar 29, 2024
@rleungx
Copy link
Member Author

rleungx commented Mar 29, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 69593bb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
Copy link
Contributor

ti-chi-bot bot commented Mar 29, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 87db551 into tikv:master Mar 29, 2024
22 checks passed
@rleungx rleungx deleted the hide-trace-region-flow branch March 29, 2024 07:43
@JmPotato JmPotato added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8008.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 1, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8064.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 7, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8146.

ti-chi-bot bot pushed a commit that referenced this pull request May 13, 2024
close #7917

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only one pd instance have trace-region-flow config by query in v6.5.6
5 participants