Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix follower cannot handle member request #8122

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 23, 2024

What problem does this PR solve?

Issue Number: Ref #7519

What is changed and how does it work?

Check List

Tests

  • Manual test

Use tiup to deploy a cluster and execute select * from cluster_info; with 3 PD.
Screenshot 2024-04-23 at 17 49 48

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 23, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and nolouch April 23, 2024 09:50
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2024
@rleungx rleungx requested review from HuSharp and lhy1024 and removed request for JmPotato and nolouch April 23, 2024 09:50
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #8122 (79f7439) into master (5cdf252) will decrease coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 79f7439 differs from pull request most recent head 2fbebca. Consider uploading reports for the commit 2fbebca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8122      +/-   ##
==========================================
- Coverage   77.29%   77.23%   -0.06%     
==========================================
  Files         470      470              
  Lines       61143    61142       -1     
==========================================
- Hits        47260    47224      -36     
- Misses      10320    10359      +39     
+ Partials     3563     3559       -4     
Flag Coverage Δ
unittests 77.23% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 23, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2024
@HuSharp
Copy link
Member

HuSharp commented Apr 24, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 79f7439

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1e65f9d into tikv:master Apr 24, 2024
22 checks passed
@rleungx rleungx deleted the fix-ms-member branch April 24, 2024 06:18
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 29, 2024
ref tikv#7519

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants