Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: improve region statistics observe #8181

Merged
merged 2 commits into from
May 17, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 16, 2024

What problem does this PR solve?

Issue Number: ref #7897.

What is changed and how does it work?

Screenshot 2024-05-16 at 17 09 35
$ benchstat old.txt new.txt
goos: linux
goarch: amd64
pkg: github.com/tikv/pd/pkg/statistics
cpu: Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz
           │   old.txt   │              new.txt               │
           │   sec/op    │   sec/op     vs base               │
Observe-72   2.134µ ± 4%   2.012µ ± 7%  -5.69% (p=0.015 n=10)

           │  old.txt   │               new.txt               │
           │    B/op    │    B/op      vs base                │
Observe-72   485.0 ± 1%   325.5 ± 49%  -32.89% (p=0.003 n=10)

           │  old.txt   │              new.txt               │
           │ allocs/op  │ allocs/op   vs base                │
Observe-72   5.000 ± 0%   3.000 ± 0%  -40.00% (p=0.000 n=10)

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 16, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 May 16, 2024 08:28
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.45%. Comparing base (59e29cc) to head (b0488a6).

Current head b0488a6 differs from pull request most recent head c92932c

Please upload reports for the commit c92932c to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8181      +/-   ##
==========================================
+ Coverage   77.41%   77.45%   +0.03%     
==========================================
  Files         471      471              
  Lines       61363    61383      +20     
==========================================
+ Hits        47503    47543      +40     
+ Misses      10288    10280       -8     
+ Partials     3572     3560      -12     
Flag Coverage Δ
unittests 77.45% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

This pull request has been accepted and is ready to merge.

Commit hash: b0488a6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2024
Copy link
Contributor

ti-chi-bot bot commented May 17, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 79083e9 into tikv:master May 17, 2024
22 checks passed
@rleungx rleungx deleted the optimize-observe branch May 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants