test/cluster_test: make TestRegionStatistics more stable #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
force-pushed
the
fix_flaky_region_test
branch
from
af36a92
to
7728bfe
Compare
rleungx
approved these changes
Jun 24, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
JmPotato
reviewed
Jun 24, 2024
| @@ -186,7 +186,7 @@ func TestRegionStatistics(t *testing.T) { | |||
| re := require.New(t) | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
| tc, err := tests.NewTestCluster(ctx, 2) | |||
| tc, err := tests.NewTestCluster(ctx, 3) | |||
There was a problem hiding this comment.
Because this test has only 2 pd's and five ResignLeader times, whenever there is a network or disk problem(ci machine has a high probability) will cause the lease to expire, and result in one more leader resigning.
And then there is a high probability of being recognized as frequent campaign times to transfer leader failed
nolouch
approved these changes
Jun 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8319
What is changed and how does it work?
Check List
Tests
Release note