tools/simulator: replace GenerateSplitKey with GenerateTableKeys #8332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot
bot
added
release-note-none
lhy1024
approved these changes
Jun 26, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
nolouch
approved these changes
Jun 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: husharp <jinhao.hu@pingcap.com>
HuSharp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
GenerateSplitKeyis less efficient and has some problems, such as wrong generate when start_key and end_key are same, and wrong generate when start_key is ""... Actually, we can replace GenerateSplitKey with GenerateTableKeys which is more line with test requirementIssue Number: Ref #8135
What is changed and how does it work?
Check List
Tests
Release note