Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/ut: replace path with filepath #8498

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Aug 6, 2024

What problem does this PR solve?

Issue Number: Ref #8475, Ref #7969

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
Signed-off-by: husharp <ihusharp@gmail.com>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (29b83fb) to head (5a09396).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8498      +/-   ##
==========================================
- Coverage   77.45%   77.35%   -0.11%     
==========================================
  Files         472      472              
  Lines       61796    61796              
==========================================
- Hits        47866    47800      -66     
- Misses      10362    10439      +77     
+ Partials     3568     3557      -11     
Flag Coverage Δ
unittests 77.35% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp requested review from lhy1024 and rleungx August 6, 2024 10:03
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 10:09:12.098516285 +0000 UTC m=+346681.965615369: ☑️ agreed by lhy1024.
  • 2024-08-06 11:27:45.312625221 +0000 UTC m=+351395.179724330: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 7ef2be0 into tikv:master Aug 6, 2024
25 checks passed
@HuSharp HuSharp deleted the replace_filepath branch August 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants