-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: fix potential data race in scheduling server #8539
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8539 +/- ##
==========================================
- Coverage 77.55% 77.54% -0.01%
==========================================
Files 474 474
Lines 61861 61859 -2
==========================================
- Hits 47974 47969 -5
- Misses 10355 10361 +6
+ Partials 3532 3529 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
} | ||
if !s.IsServing() { | ||
// double check | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a break label
to indicate jumping out of the “for loop”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not necessary.
ref #8538 (comment) Is there a way to make |
There seems to be no easy way to implement this, and similar problems may also occur in scenarios where there are network problems. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: lhy1024 <admin@liudos.us>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: Close #8538
What is changed and how does it work?
Check List
Tests
Release note