schedule: fix datarace in operator.check (#8264)

[ti-chi-bot]

This is an automated cherry-pick of #8264

What problem does this PR solve?

Issue Number: Close #8263

What is changed and how does it work?

Check List

Tests

• Unit test
• Manual test (add detailed scripts or steps below)
  go test -timeout 120s -run ^TestOperatorCheckConcurrently$ github.com/tikv/pd/pkg/schedule/operator -race
• in master

==================
WARNING: DATA RACE
Read at 0x00c0004dc240 by goroutine 212:
  github.com/tikv/pd/pkg/schedule/operator.(*Operator).Check()
      /home/lhy1024/pd/pkg/schedule/operator/operator.go:382 +0x5c4
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently.func1()
      /home/lhy1024/pd/pkg/schedule/operator/operator_test.go:593 +0xbe

Previous write at 0x00c0004dc240 by goroutine 215:
  sync/atomic.CompareAndSwapInt64()
      /usr/lib/go/src/runtime/race_amd64.s:316 +0xb
  sync/atomic.CompareAndSwapInt64()
      <autogenerated>:1 +0x1a
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently.func1()
      /home/lhy1024/pd/pkg/schedule/operator/operator_test.go:593 +0xbe

Goroutine 212 (running) created at:
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently()
      /home/lhy1024/pd/pkg/schedule/operator/operator_test.go:591 +0x487
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /usr/lib/go/src/testing/testing.go:1742 +0x44

Goroutine 215 (running) created at:
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently()
      /home/lhy1024/pd/pkg/schedule/operator/operator_test.go:591 +0x487
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /usr/lib/go/src/testing/testing.go:1742 +0x44
==================
--- FAIL: TestOperatorCheckConcurrently (0.00s)
    testing.go:1398: race detected during execution of test
FAIL
FAIL    github.com/tikv/pd/pkg/schedule/operator        0.103s
FAIL

• with this pr

ok      github.com/tikv/pd/pkg/schedule/operator        1.098s

Release note

None.

[HuSharp]

In release 7.1, run test will meet data race only for variable time.

go clean -testcache 
go test -timeout 120s -run ^TestOperatorCheckConcurrently$ github.com/tikv/pd/server/schedule/operator -race

pingcap@MacBook-Pro-2 ~/CS/PingCAP/pd
cherry-pick-8264-to-release-6.5* $ go test -timeout 120s -run ^TestOperatorCheckConcurrently$ github.com/tikv/pd/server/schedule/operator -race                                                                                                               ==================
WARNING: DATA RACE
Read at 0x00c0005aa228 by goroutine 167:
  github.com/tikv/pd/pkg/schedule/operator.(*Operator).Check()
      /Users/pingcap/CS/PingCAP/pd/pkg/schedule/operator/operator.go:317 +0x418
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently.func1()
      /Users/pingcap/CS/PingCAP/pd/pkg/schedule/operator/operator_test.go:553 +0x8c

Previous write at 0x00c0005aa228 by goroutine 166:
  ??()
      -:0 +0x1041769f4
  sync/atomic.CompareAndSwapInt64()
      <autogenerated>:1 +0x18
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently.func1()
      /Users/pingcap/CS/PingCAP/pd/pkg/schedule/operator/operator_test.go:553 +0x8c

Goroutine 167 (running) created at:
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently()
      /Users/pingcap/CS/PingCAP/pd/pkg/schedule/operator/operator_test.go:551 +0x368
  testing.tRunner()
      /opt/homebrew/opt/go/libexec/src/testing/testing.go:1595 +0x1b0
  testing.(*T).Run.func1()
      /opt/homebrew/opt/go/libexec/src/testing/testing.go:1648 +0x40

Goroutine 166 (running) created at:
  github.com/tikv/pd/pkg/schedule/operator.TestOperatorCheckConcurrently()
      /Users/pingcap/CS/PingCAP/pd/pkg/schedule/operator/operator_test.go:551 +0x368
  testing.tRunner()
      /opt/homebrew/opt/go/libexec/src/testing/testing.go:1595 +0x1b0
  testing.(*T).Run.func1()
      /opt/homebrew/opt/go/libexec/src/testing/testing.go:1648 +0x40
==================
--- FAIL: TestOperatorCheckConcurrently (0.00s)
    testing.go:1465: race detected during execution of test
FAIL
FAIL    github.com/tikv/pd/pkg/schedule/operator        0.574s
FAIL

[ti-chi-bot]

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HuSharp,lhy1024]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-27 08:56:00.048173269 +0000 UTC m=+860555.182623391: ☑️ agreed by lhy1024.
• 2024-09-06 06:02:23.141057935 +0000 UTC m=+597067.659110855: ☑️ agreed by HuSharp.