Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for windows #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Testing for windows #122

wants to merge 1 commit into from

Conversation

Jardynq
Copy link

@Jardynq Jardynq commented May 1, 2022

Removed any linux dependency that was interfering with compilation.

Added a new worker thread, that enumerates all other threads and grabs that backtrace using the forked backtrace-rs.

Removed any linux dependency that was interfering with compilation.

Added a new worker thread, that enumerates all other threads and grabs that backtrace using the forked backtrace-rs.
@Jardynq Jardynq mentioned this pull request May 1, 2022
@Jardynq Jardynq marked this pull request as ready for review May 1, 2022 12:28
Copy link

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use conditional compilation via #[cfg(windows)) and #[not(cfg(windows))] instead of removing the lines of code.

@Jardynq
Copy link
Author

Jardynq commented May 4, 2022

@aminya Of course. I just removed it for testing purposes. It might make sense to move each implementation into their own file.

@aminya
Copy link

aminya commented Jul 3, 2022

@Jardynq Yeah, if the goal is to merge this, we should probably do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants