Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prost to 0.8 #55

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Update prost to 0.8 #55

merged 3 commits into from
Sep 13, 2021

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Sep 6, 2021

Update Prost to 0.8, to avoid security issue of 0.7 (RUSTSEC-2021-0073).
Related issue: tikv/tikv#10905

Signed-off-by: pingyu shui.yu@126.com

Signed-off-by: pingyu <shui.yu@126.com>
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the crate version needs to be changed to 0.13, so the dependents using 0.12 won't be affected.

cc @BusyJay

@BusyJay
Copy link
Member

BusyJay commented Sep 8, 2021

Agree.

Signed-off-by: pingyu <shui.yu@126.com>
@pingyu
Copy link
Contributor Author

pingyu commented Sep 8, 2021

/cc @sticnarf

I think the crate version needs to be changed to 0.13, so the dependents using 0.12 won't be affected.

cc @BusyJay

Comment addressed. PTAL~

@pingyu
Copy link
Contributor Author

pingyu commented Sep 11, 2021

Can this PR be merged ?

@TennyZhuang
Copy link

/merge

@BusyJay
Copy link
Member

BusyJay commented Sep 13, 2021

It seems to still depend on 0.7.

@zhouqiang-cl zhouqiang-cl merged commit ce7b34c into tikv:master Sep 13, 2021
@pingyu
Copy link
Contributor Author

pingyu commented Sep 13, 2021

It seems to still depend on 0.7.

It seems to indirectly depend on 0.7 from grpcio-compiler.
I will fire another PR to fix it.

[package]
name = "grpcio-compiler"
...

[dependencies]
protobuf = { version = "2", optional = true }
prost = { version = "0.7", optional = true }
prost-build = { version = "0.7", optional = true }
prost-types = { version = "0.7", optional = true }
derive-new = { version = "0.5", optional = true }
tempfile = { version = "3.0", optional = true }
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants